Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch scalesets to delete asynchronously without waiting on future #3221

Merged
merged 1 commit into from
Jun 18, 2020
Merged

switch scalesets to delete asynchronously without waiting on future #3221

merged 1 commit into from
Jun 18, 2020
+34 −10

Conversation

marwanad
Copy link
Member

Splits DeleteInstances into an operation call + async wait so we don't block main thread when the main loop is deleting unregistered instances.

/area provider/azure

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2020
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and nilo19 June 15, 2020 04:53
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 15, 2020
@marwanad
Copy link
Member Author

test failures are on the AWS side and unrelated

feiskyer
feiskyer reviewed Jun 16, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2020
@nilo19
Copy link
Member

nilo19 commented Jun 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9a1f3fe into kubernetes:master Jun 18, 2020
This was referenced Jul 6, 2020
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 6, 2020
@k8s-ci-robot
Merge pull request #3292 from marwanad/1.18-cherry-pick-3221-and-3284
fd1a370 
Cherry-pick #3221, #3284 - Async Deletions and 409 Conflicts
k8s-ci-robot added a commit that referenced this pull request Jul 6, 2020
@k8s-ci-robot
Merge pull request #3291 from marwanad/1.15-cherry-pick-3221-and-3284
c310cca 
Cherry-pick #3221, #3284 - Async Deletions and 409 Conflicts
k8s-ci-robot added a commit that referenced this pull request Jul 6, 2020
@k8s-ci-robot
Merge pull request #3290 from marwanad/1.16-cherry-pick-3221-and-3284
0a517af 
Cherry-pick #3221, #3284 - Async Deletions and 409 Conflicts
k8s-ci-robot added a commit that referenced this pull request Jul 6, 2020
@k8s-ci-robot
Merge pull request #3289 from marwanad/1.17-cherry-pick-3221-and-3284
b7eea7e 
Cherry-pick #3221, #3284 - Async Deletions and 409 Conflicts
@marwanad marwanad deleted the parallel-deletes branch August 21, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@feiskyer feiskyer

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marwanad @k8s-ci-robot @nilo19 @feiskyer